Move check for plus usage endpoint to correct spot #2904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2904 +/- ##
=======================================
Coverage 89.74% 89.74%
=======================================
Files 109 109
Lines 11150 11150
Branches 50 50
=======================================
Hits 10007 10007
Misses 1083 1083
Partials 60 60 ☔ View full report in Codecov by Sentry. |
sjberman
approved these changes
Dec 13, 2024
salonichf5
approved these changes
Dec 13, 2024
kate-osborn
added a commit
that referenced
this pull request
Dec 13, 2024
Problem: #2902 moved check-for-plus-usage-endpoint dependency to the wrong Makefile target which caused the pipelines on main to fail. Solution: Move check-for-plus-usage-endpoint` dependency to the right target.
kate-osborn
added a commit
that referenced
this pull request
Dec 13, 2024
Problem: #2902 moved check-for-plus-usage-endpoint dependency to the wrong Makefile target which caused the pipelines on main to fail. Solution: Move check-for-plus-usage-endpoint` dependency to the right target.
kate-osborn
added a commit
that referenced
this pull request
Dec 13, 2024
Problem: #2902 moved check-for-plus-usage-endpoint dependency to the wrong Makefile target which caused the pipelines on main to fail. Solution: Move check-for-plus-usage-endpoint` dependency to the right target.
kate-osborn
added a commit
that referenced
this pull request
Dec 13, 2024
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Problem: nginx#2902 moved check-for-plus-usage-endpoint dependency to the wrong Makefile target which caused the pipelines on main to fail. Solution: Move check-for-plus-usage-endpoint` dependency to the right target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: #2902 moved
check-for-plus-usage-endpointdependency to the wrong Makefile target which caused the pipelines on main to fail.Solution: Move check-for-plus-usage-endpoint` dependency to the right target.